This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql: use custom boolean coercion logic in condition evaluation #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
fix/bool-coercion
branch
from
ee455f0
to
568f586
Compare
juanjux
reviewed
Jun 24, 2019
| return b, nil | ||
| case int, int64, int32, int16, int8, uint, uint64, uint32, uint16, uint8: | ||
| return b != 0, nil | ||
| case time.Duration: |
There was a problem hiding this comment.
Should a Duration or time really ever evaluate to false?
There was a problem hiding this comment.
when it's 0, i guess
There was a problem hiding this comment.
But those are valid dates/durations. Anyway it's very minor; we should probably just do whatever MySQL do in these cases.
juanjux
approved these changes
Jun 24, 2019
kuba--
reviewed
Jun 24, 2019
| case float32, float64: | ||
| return int(math.Round(v.(float64))) != 0, nil | ||
| default: | ||
| return false, nil |
There was a problem hiding this comment.
how about the string:
select 1 from dual where "1";
basically it false, but for above string it's true for mysql.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for src-d/gitbase#902
The idea is to use
EvaluateConditionas a common logic for filtering in both gitbase squashed tables and go-mysql-server.Right now, in go-mysql-server we just check the result
== true, which not only is not correct but is not consistent with how gitbase does it.In gitbase we use
sql.Boolean.Convert, but by definition the convert method of boolean can't handle some types.That's why I added some helper function for this with the type coercion logic that we can also reuse on gitbase.