This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql: fix how nulls are sent to clients #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjux
approved these changes
Jul 3, 2019
kuba--
approved these changes
Jul 3, 2019
ajnavarro
approved these changes
Jul 3, 2019
ajnavarro
reviewed
Jul 4, 2019
| @@ -175,6 +175,8 @@ func DefaultSessionConfig() map[string]TypedValue { | |||
| "ndbinfo_version": TypedValue{Text, ""}, | |||
| "sql_select_limit": TypedValue{Int32, math.MaxInt32}, | |||
| "transaction_isolation": TypedValue{Text, "READ UNCOMMITTED"}, | |||
| "version": TypedValue{Text, ""}, | |||
There was a problem hiding this comment.
Maybe we can add the real version here to maintain consistency.
There was a problem hiding this comment.
What version should we put? A fake mysql version? It might not be consistent with VERSION() though
There was a problem hiding this comment.
we cannot use the same param as VERSION() is using here?
There was a problem hiding this comment.
That's the thing, VERSION() doesn't even exist in plain go-mysql-server. It's registered in gitbase with a specific version.
There was a problem hiding this comment.
oh, right, I mix both. Sorry for the noise.
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
fix/display-nulls
branch
from
ad130ae
to
688a79f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
Fixing this, connecting from MySQL client broke. After much debugging, turns out it was because
@@versionand@@version_commentdidn't exist (and thus, they were null), but the client was expecting something there. I just added both, but left them empty and the problem goes away.