Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Zachmu/bug fixes to contribute #784

Merged
merged 16 commits into from
Jul 10, 2019
Merged

Zachmu/bug fixes to contribute #784

merged 16 commits into from
Jul 10, 2019

Commits on Jul 9, 2019

  1. Fixed float comparisons, added lots of tests for same. 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    8f2dafc View commit details
    Browse the repository at this point in the history

  2. Formatted new tests more succinctly. 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    1590eb3 View commit details
    Browse the repository at this point in the history

  3. Removed redundant tests, added an order by test 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    c6d9cae View commit details
    Browse the repository at this point in the history

  4. Fixed remaining broken tests 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    725d21a View commit details
    Browse the repository at this point in the history

  5. Implemented is true / is false expressions 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ecd0be7 View commit details
    Browse the repository at this point in the history

  6. Added new table with nil values 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    00b8a2f View commit details
    Browse the repository at this point in the history

  7. Lots more tests of IS NULL, IS TRUE, etc. 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    c5c6fcf View commit details
    Browse the repository at this point in the history

  8. Uncommented test cases 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ce330c4 View commit details
    Browse the repository at this point in the history

  9. Fix broken test for not expression 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    e522139 View commit details
    Browse the repository at this point in the history

  10. Fixed bug in comparisons for negative float literals 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    072ad2b View commit details
    Browse the repository at this point in the history

  11. After merging from master, replace vitess with our forked version 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    35c0ecc View commit details
    Browse the repository at this point in the history

  12. Reverting local changes to go.mod 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    6f9a12a View commit details
    Browse the repository at this point in the history

  13. Fixed an error in receiver type for String() method of IsTrue 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    fb26ee9 View commit details
    Browse the repository at this point in the history

  14. Fixed a typo 

    Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    f86f7e2 View commit details
    Browse the repository at this point in the history

  15. Fixed bug in is false evaluation for nil values. Added tests for bool… 

    … evaluation of string fields. This required allowing conversion of strings to bool (always false, as MySQL). This in turn exposed a bug in optimization, where non-column expressions were inappropriately getting coerced into boolean values. Removed the boolean casting, which is slightly less performant but correct in all cases.

Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ded9391 View commit details
    Browse the repository at this point in the history

  16. Updated IsTrue to use the new Expression interface (TransformUp -> Wi… 

    …thChildren)

Signed-off-by: Zach Musgrave <zach@liquidata.co>
    @zachmu
    zachmu committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    99dc027 View commit details
    Browse the repository at this point in the history