Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql: implement count distinct #785

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

erizocosmico
Copy link
Contributor

No description provided.

@erizocosmico erizocosmico added the enhancement New feature or request label Jul 5, 2019
@erizocosmico erizocosmico requested a review from a team July 5, 2019 10:39
@erizocosmico erizocosmico self-assigned this Jul 5, 2019
@erizocosmico erizocosmico force-pushed the feature/count-distinct branch 2 times, most recently from 23da2e9 to 166881a Compare July 5, 2019 11:04
@kuba--
Copy link
Contributor

kuba-- commented Jul 5, 2019

LGTM after the tests pass (TestParseErrors/SELECT_COUNT(DISTINCT_foo)_FROM_b (0.00s))

@erizocosmico
Copy link
Contributor Author

It's passing now. (CI is not because openjdk10 stuff

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@ajnavarro ajnavarro merged commit b61703a into src-d:master Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants