Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

function: implement regexp_matches #794

Merged
merged 1 commit into from
Aug 8, 2019
Merged

function: implement regexp_matches #794

merged 1 commit into from
Aug 8, 2019

Conversation

erizocosmico
Copy link
Contributor

Closes #756

@erizocosmico erizocosmico requested a review from a team August 5, 2019 12:03
juanjux
juanjux approved these changes Aug 7, 2019
View reviewed changes
engine_test.go Show resolved Hide resolved
sql/expression/function/regexp_matches_test.go Show resolved Hide resolved
@erizocosmico
function: implement regexp_matches
8e04eac 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Done @juanjux

ajnavarro
ajnavarro approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you check CI please?

@erizocosmico
Copy link
Contributor Author

@ajnavarro it was a temporary error downloading dependencies, restarted the failing job

@ajnavarro ajnavarro merged commit ffb743d into src-d:master Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@agarciamontoro agarciamontoro Awaiting requested review from agarciamontoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for regexp_matches
3 participants
@erizocosmico @juanjux @ajnavarro