This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Fixed null errors during value comparisons #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daylon Wilkins <daylon@liquidata.co>
Merged
erizocosmico
approved these changes
Oct 1, 2019
juanjux
approved these changes
Oct 1, 2019
agarciamontoro
approved these changes
Oct 1, 2019
|
Ignoring node integration tests for now and merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was discovered while creating #832, and is required for one of the tests in that PR to pass.
Null values weren't being handled in most of the value comparison code, and was causing errors for valid queries. This PR fixes those issues.