-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slice bounds out of range error #163
Comments
This is clearly a crash @Gr33nbl00d Can you send me the repo you analyzed; if it is not possible, I will try to suggest fixes but I will need your assistance to test. |
Hi no problem it is quite problematic to send you this repo as it is really big 1.7M Lines of Code and also im not allowed as it is confidential. Its is reproducable and crashes always on the same step with the same error. No Problem i will try to help :) |
OK. If you are able to build Hercules, then I can send you a patch which prints the hashes of the two offending compared Git blobs, then you execute |
Yes sounds good, but i have to admit i never worked with GO yet ;) so i have to fiddle a bit arround to find out how to compile it :) |
@Gr33nbl00d Please use the binary from "debug" release, it contains the patch: https://github.com/src-d/hercules/releases/tag/debug |
thank you i will try |
ok the new output is: hercules --devs . | python labours.py -m devs goroutine 4846 [running]: No data has been read - has Hercules crashed? |
Good, so now I need you to run
And send me those two files. My email can be taken from e.g. https://github.com/src-d/hercules/commit/b8fb564c3acd2da61027c9f909a22e33c9c1626b.patch |
i send you a link with the files direct sending of files did not work because of an email gateway error i got. Florian |
I downloaded the files successfully, thanks. I will reproduce the problem this week and push the fix asap. |
Ok no Problem take your time :) I am glad i could help and looking forward for your fix :) |
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Fixes src-d#163 Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
@Gr33nbl00d Looks like I fixed the bug. I am publishing a new release later today. |
Should be fixed in https://github.com/src-d/hercules/releases/tag/v7 |
What i get after running
hercules --devs <repo> | python labours.py -m devs
2417 / 29722 1h58m45spanic: runtime error: slice bounds out of range
goroutine 4816 [running]:
gopkg.in/src-d/hercules.v6/internal/plumbing.(*RenameAnalysis).blobsAreClose(0xc000a49580, 0xc04aa1e370, 0xc00c8b60a0, 0xc00b80ee48, 0x9, 0xc0933c3f90)
c:/gopath/src/gopkg.in/src-d/hercules.v6/internal/plumbing/renames.go:411 +0xb30
gopkg.in/src-d/hercules.v6/internal/plumbing.(*RenameAnalysis).Consume.func1(0x0, 0x0)
c:/gopath/src/gopkg.in/src-d/hercules.v6/internal/plumbing/renames.go:232 +0x41b
gopkg.in/src-d/hercules.v6/internal/plumbing.(*RenameAnalysis).Consume.func3(0xc00b313950, 0xc00650cd30)
c:/gopath/src/gopkg.in/src-d/hercules.v6/internal/plumbing/renames.go:314 +0x2e
created by gopkg.in/src-d/hercules.v6/internal/plumbing.(*RenameAnalysis).Consume
c:/gopath/src/gopkg.in/src-d/hercules.v6/internal/plumbing/renames.go:314 +0x1a7b
No data has been read - has Hercules crashed?
The text was updated successfully, but these errors were encountered: