Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a single file processing API #6

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Expose a single file processing API #6

merged 1 commit into from
Nov 26, 2019

Conversation

dennwc
Copy link

@dennwc dennwc commented Nov 25, 2019 •
edited
Loading

Expose an API to extract imports from a single file.

Also some minor improvements:

  • Add comments to the API
  • Print all files in CLI, even if language was not recogized.
  • Reduce the default max size from 10M to 1M.
  • In CLI, try extracting imports even from large files by processing a 1M sample.

Signed-off-by: Denys Smirnov denys@sourced.tech

This change is Reviewable

expose a single file processing API; print all files; reduce default …
eb22bdf 
…max size

Signed-off-by: Denys Smirnov <denys@sourced.tech>
@dennwc dennwc added the enhancement New feature or request label Nov 25, 2019
@dennwc dennwc requested a review from kuba-- November 25, 2019 13:48
@dennwc dennwc self-assigned this Nov 25, 2019
kuba--
kuba-- approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be reviewed by someone who will integrate it (e.g. Alex)

@kuba-- kuba-- merged commit d888ea9 into master Nov 26, 2019
@kuba-- kuba-- deleted the lib-api branch November 26, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuba-- kuba-- kuba-- approved these changes

Assignees

@dennwc dennwc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennwc @kuba--