Add sql subcommand for gitbase mysql client #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
suggested changes
Jun 12, 2019
carlosms
reviewed
Jun 12, 2019
cmd/sourced/cmd/sql.go
Outdated
| ) | ||
|
|
||
| type sqlCmd struct { | ||
| Command `name:"sql" short-description:"Open a mysql client connected for gitbase" long-description:"Open a mysql client connected for gitbase"` |
There was a problem hiding this comment.
Suggested change
| Command `name:"sql" short-description:"Open a mysql client connected for gitbase" long-description:"Open a mysql client connected for gitbase"` | |
| Command `name:"sql" short-description:"Open a MySQL client connected to gitbase" long-description:"Open a MySQL client connected to gitbase"` |
|
Will it work on windows? |
|
Thanks! Re-pushed with updated documentation. It should work on windows. (at least |
|
works as a charm (srcd was inited without repos): |
carlosms
reviewed
Jun 13, 2019
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ The `sourced` binary is a wrapper for Docker Compose that downloads the `docker- | |||
| - `stop`: Stop running containers | |||
| - `start`: Start stopped containers | |||
| - `web`: Open the web interface in your browser | |||
| - `sql`: Open a MySQL client connected for gitbase | |||
There was a problem hiding this comment.
Suggested change
| - `sql`: Open a MySQL client connected for gitbase | |
| - `sql`: Open a MySQL client connected to gitbase |
README.md
Outdated
| sourced sql | ||
| ``` | ||
|
|
||
| Open a MySQL client connected for gitbase. |
There was a problem hiding this comment.
Suggested change
| Open a MySQL client connected for gitbase. | |
| Open a MySQL client connected to gitbase. |
cmd/sourced/cmd/sql.go
Outdated
| ) | ||
|
|
||
| type sqlCmd struct { | ||
| Command `name:"sql" short-description:"Open a MySQL client connected for gitbase" long-description:"Open a MySQL client connected for gitbase"` |
There was a problem hiding this comment.
Suggested change
| Command `name:"sql" short-description:"Open a MySQL client connected for gitbase" long-description:"Open a MySQL client connected for gitbase"` | |
| Command `name:"sql" short-description:"Open a MySQL client connected to gitbase" long-description:"Open a MySQL client connected to gitbase"` |
carlosms
approved these changes
Jun 13, 2019
Signed-off-by: Maxim Sukharev <max@smacker.ru>
|
for/to changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maxim Sukharev max@smacker.ru