Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change add_context_info method in typos #616

Merged
merged 6 commits into from
Feb 21, 2019

Conversation

irinakhismatullina
Copy link
Contributor

@irinakhismatullina irinakhismatullina commented Feb 15, 2019

In utils.add_context_info() save context parts as strings (space-separated-tokens) , not lists.
Example: instead of ["get", "token"] use "get token".

Simplifies storing datasets in .csv files.

Based on #626.

@vmarkovtsev
Copy link
Collaborator

@irinakhismatullina Now we need to rebase here

Signed-off-by: Irina <irenekhismatullina@gmail.com>
Signed-off-by: Irina <irenekhismatullina@gmail.com>
Signed-off-by: Irina <irenekhismatullina@gmail.com>
Signed-off-by: Irina <irenekhismatullina@gmail.com>
Signed-off-by: Irina <irenekhismatullina@gmail.com>
Copy link
Contributor

@m09 m09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the semantic changes themselves since it's out of context in this PR. More generally, the files contain many wrong type annotations where an Optional is lacking. When a default value is None, an Optional[] is needed.

lookout/style/typos/corrector.py Outdated Show resolved Hide resolved
lookout/style/typos/corrector.py Outdated Show resolved Hide resolved
lookout/style/typos/generation.py Outdated Show resolved Hide resolved
lookout/style/typos/generation.py Outdated Show resolved Hide resolved
lookout/style/typos/generation.py Outdated Show resolved Hide resolved
Signed-off-by: Irina <irenekhismatullina@gmail.com>
@m09 m09 merged commit a2f7082 into src-d:master Feb 21, 2019
@irinakhismatullina irinakhismatullina deleted the feature/change-add-context branch February 22, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants