Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible missing treesitter support for italic, bold, italic, underline and strikethrough #117

Closed
Sberlos opened this issue Mar 21, 2024 · 1 comment

Comments

@Sberlos
Copy link

Sberlos commented Mar 21, 2024

Hello,

first of all I would like to thank you for the amazing color scheme, it is my default one since many years on all my machines.

I am a neovim user and I started using the neorg plugin for note taking. This plugin has the possibility to style text as bold, italic, underline and strikethrough. Sadly, I discovered that those text decorations are not working with srcery. I opened the same file containing the decorations using the kanagawa color scheme and they displayed correctly. This suggests me that the problem may be with srcery. I don't know much about color schemes in vim/neovim but I know that neorg uses Treesitter extensively and for this reason I suppose the lack of decorations is tied to the missing support of some part of it.

I don't know if it would be of any help, but neorg defines the highlighting of text decorations here and they correspond on the values that I see in neovim when I invoke :Inspect on the corresponding decorated word.

For information, I am using neovim 0.9.5-2 and the latest version of both neorg and srcery. I am using srcery with the default configuration except for the srcery_italic variable which I have set to 1.

I understand that this might be a niche user-case and that you might not have neorg nor neovim installed and I would be happy to do anything to help identify the problem.

Thank you in advance!

roosta added a commit that referenced this issue Mar 26, 2024
Uses new strikethrough variable, see b5e21ff

Fixes: #117
@roosta roosta mentioned this issue Mar 26, 2024
2 tasks
@roosta
Copy link
Member

roosta commented Mar 26, 2024

Hi! Thanks for opening an issue, I was able to figure out why this wasn't working, and I have submitted a PR with a fix. If you could try the branch and confirm it is working?

@roosta roosta closed this as completed in 7439a86 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants