Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling #92

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix bundling #92

merged 2 commits into from
Nov 7, 2022

Conversation

ofirelarat
Copy link
Collaborator

@ofirelarat ofirelarat commented Nov 5, 2022

fixing Invalid hook call
as in issue #91

I have checked the bundle in the example and also pack the project and test it in another react app

@ofirelarat ofirelarat mentioned this pull request Nov 5, 2022
Copy link
Owner

@srdjan srdjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -43,10 +45,10 @@
"react-test-renderer": "17.0.2"
},
"peerDependencies": {
"react": "17.0.2"
"react": "^17.0.0 || ^18.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 like it!

@ofirelarat ofirelarat merged commit 8f24fd1 into srdjan:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants