Hotfix/postinstall #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Setup base project files under `./src` - Setup Rollup bundling to Javascript as ES and CommonJS file formats - Using unit testing from Typescript files instead of the Javascript files; maybe look at this later - gitignore and npmignore files setup Issues: - No unit tests yet - No engine running yet - Very touchy for the type of module loading I'm using; need to look into different module loading Comments: - Need to look into CommonJS vs ES vs AMD module loading - For my project, should I look into building this just as a web app, or look into building this to an Electron application as well? - I have a lot of devDependencies, is there a way to start cutting these down?
Changes: Added in documentation building with the 'npm run docs' command. Going to continue adding scripts to build the project, as I will eventually need to add in additional build steps for running the engine. Also updated the Rollup bundler to use Babel to compile from the projects target modules ESNext to CommonJS modules for consumption. This threw errors when running Mocha tests. I now have an environment variable being set by the 'unittest' script for the user. Issues: * None found at this time. Comments: None at this time.
Changes: Updated Rollup to bundle files from ESNext to Javascript. Working on unit testing the engine to test running of the engine. Going to have to redesign and configure however. Issues: * Still working on getting unit testing working * Redesign of the engine needs to occur Comments: The engine needs to be redesigned. I'm debating between a static calling of the class or a variable to hold onto the object to check. Either way, also need to get the engine and each component to work separately for testing as well.
Changes: Updated unit tests for the engine. Added DObject, GameObject, Component, and FlagComponent classes with test cases. Currently debugging and working on but would like to set a save point to continue working later. Working on GameObjects currently so that I test getting developer game files when deploying the engine to a new project. This will also be tested for when the developer compiles all the typescript files and deploys. This should be compiled through the engine when running. Issues: Unit test cases currently failing, working on solutions and implementations. Comments: Still working on the base engine to get it running and off the ground. Will As soon as some more base classes are in then I will work on bundling the package and running on Electron or Angular as a test.
Changes: Added the GameWindow class. Should this have the direct link to the canvas or should the Render system 🤔? (I will ponder this). That said, this will be the container to the window (so maybe it should have all the udpate calls and such, but the renderer should touch it as well). Also added some documentation building to the `docs` folder now. Issues: The GameWindow class is going to take some working on to get right. Going to have to do some testing with how it will work with the render system. Comments: Add some prepublish scripts to build and deploy the documents. Maybe I can get a hook to a website for this? I don't know quite yet. Also going to have to get Travis-CI working sooner than later. Maybe those will be my tasks for tomorrow
Changes: Added an initial version of the readme. I've looked at other project's readmes, and this is one of the best templates I've found. Going to bulid off of it for my project. More to come and be added, but would like an initial file. Issues: See previous commit 7cc6c9a. Comments: None
Changes: Added an initial Travis-CI script to run unit tests Issues: None Comments: None
Changes: Fixed Travis file to run master and develop branches only. Also added documentation pushing and building to Github Pages from the docs folder. Issues: None Comments: None
Changes: [This should be an overall summary of changes to the project at least done in point-form. More detailed prose format is of course allowed. The point of the description is to provide detail of changes and why.] Issues: [Please provide a point-form description of issues. Then please submit a formal issue on the GitHub project. Issue guidelines are doucmented in the project Wiki.] Comments: [Other general comments you wish to add]
Changes: The developer will need to use my engine within their project - being browser, Electron or Angular based (working on just browser/electron first). Issues: - When trying to test Electron.BrowserWindow within Mocha test, running into an error where the BrowserWindow constructor is undefined. For now I have the test not running at all. Comments: Developers first setup their own project THEN use my application within it (install or download it). Going to have to do some major revisions, but I think the best thing to do is make a diagram explaining this in a system architecture diagram. Going to have to do some thinking over the next week on how to do this, but also just need to sit down and work when I get back on it.
Changes: Added the CONTRIBUTING.md file to the project tree in ready to submit the first projects pull request. Issues: none Comments: none
* Building, unit testing, some base files Changes: - Setup base project files under `./src` - Setup Rollup bundling to Javascript as ES and CommonJS file formats - Using unit testing from Typescript files instead of the Javascript files; maybe look at this later - gitignore and npmignore files setup Issues: - No unit tests yet - No engine running yet - Very touchy for the type of module loading I'm using; need to look into different module loading Comments: - Need to look into CommonJS vs ES vs AMD module loading - For my project, should I look into building this just as a web app, or look into building this to an Electron application as well? - I have a lot of devDependencies, is there a way to start cutting these down? * Documentation building and compiling issues Changes: Added in documentation building with the 'npm run docs' command. Going to continue adding scripts to build the project, as I will eventually need to add in additional build steps for running the engine. Also updated the Rollup bundler to use Babel to compile from the projects target modules ESNext to CommonJS modules for consumption. This threw errors when running Mocha tests. I now have an environment variable being set by the 'unittest' script for the user. Issues: * None found at this time. Comments: None at this time. * Compiling, unit testing and Rollup fixes Changes: Updated Rollup to bundle files from ESNext to Javascript. Working on unit testing the engine to test running of the engine. Going to have to redesign and configure however. Issues: * Still working on getting unit testing working * Redesign of the engine needs to occur Comments: The engine needs to be redesigned. I'm debating between a static calling of the class or a variable to hold onto the object to check. Either way, also need to get the engine and each component to work separately for testing as well. * Added new engine files and unit testing Changes: Updated unit tests for the engine. Added DObject, GameObject, Component, and FlagComponent classes with test cases. Currently debugging and working on but would like to set a save point to continue working later. Working on GameObjects currently so that I test getting developer game files when deploying the engine to a new project. This will also be tested for when the developer compiles all the typescript files and deploys. This should be compiled through the engine when running. Issues: Unit test cases currently failing, working on solutions and implementations. Comments: Still working on the base engine to get it running and off the ground. Will As soon as some more base classes are in then I will work on bundling the package and running on Electron or Angular as a test. * GameWindow and Documents Changes: Added the GameWindow class. Should this have the direct link to the canvas or should the Render system 🤔? (I will ponder this). That said, this will be the container to the window (so maybe it should have all the udpate calls and such, but the renderer should touch it as well). Also added some documentation building to the `docs` folder now. Issues: The GameWindow class is going to take some working on to get right. Going to have to do some testing with how it will work with the render system. Comments: Add some prepublish scripts to build and deploy the documents. Maybe I can get a hook to a website for this? I don't know quite yet. Also going to have to get Travis-CI working sooner than later. Maybe those will be my tasks for tomorrow * Initial Readme Changes: Added an initial version of the readme. I've looked at other project's readmes, and this is one of the best templates I've found. Going to bulid off of it for my project. More to come and be added, but would like an initial file. Issues: See previous commit 7cc6c9a. Comments: None * Travis-CI script Changes: Added an initial Travis-CI script to run unit tests Issues: None Comments: None * Specifying branches for Travis-CI and uploading documentation Changes: Fixed Travis file to run master and develop branches only. Also added documentation pushing and building to Github Pages from the docs folder. Issues: None Comments: None * Set theme jekyll-theme-merlot * Updated travis.yml * Added Travis-CI button None * 😕 Had to update mocha * Updated package.json and tslint Changes: [This should be an overall summary of changes to the project at least done in point-form. More detailed prose format is of course allowed. The point of the description is to provide detail of changes and why.] Issues: [Please provide a point-form description of issues. Then please submit a formal issue on the GitHub project. Issue guidelines are doucmented in the project Wiki.] Comments: [Other general comments you wish to add] * I finally get it 🔥 Changes: The developer will need to use my engine within their project - being browser, Electron or Angular based (working on just browser/electron first). Issues: - When trying to test Electron.BrowserWindow within Mocha test, running into an error where the BrowserWindow constructor is undefined. For now I have the test not running at all. Comments: Developers first setup their own project THEN use my application within it (install or download it). Going to have to do some major revisions, but I think the best thing to do is make a diagram explaining this in a system architecture diagram. Going to have to do some thinking over the next week on how to do this, but also just need to sit down and work when I get back on it. * Contributing file added Changes: Added the CONTRIBUTING.md file to the project tree in ready to submit the first projects pull request. Issues: none Comments: none
Loading the shaders was a dumb error. Had the fragment shader loading as a vertex shader (bad copy/pasta). Continuing to build the basic scene now. Going to have to do a lot of finniking to get this working on time.
Worked to get the renderer working, and still nothing is happening. I think this may be more trouble than it's worth, especially with the time frame that I have. I'm going to call it here to get ThreeJS working again. It's should remove most of the complexity in this aspect.
This really didn't take that long, and I'm a little upset at myself for not doing this sooner and more efficiently. This is not using the scene in my testing project, but just a set scene in the render system that will have to be removed.
Should be rendering entities now, but things are going wonky on getting the scenes in my testing project. Going to troubleshoot this in the AM. Not much left before I can really start striding into place with my project. This seems to be going smoothly for the most part.
…tatus Reviewed and revised the README document to update it with current information of the project. This was mostly completed to write and update my final report for the project. This will be cherrypicked and applied to the master branch.
Worked on getting the sprite system implemented, but it began taking up too much time. Going to push this off for now and continue working on getting movement and physics implemented first. Going to take a bit of time, but I've got some ideas on the back burner for now. Also working on the report along side work to get things done on time.
Worked on getting textures implemented into the engine. Cannot successfully get them loading in my test electron project from the assets folder. Continuting to work on this over time. Working on fixing the tests to get the working properly. There are a lot failing and out of date that need to be udpated, so these are being addressed now. Continuing to work on them as the night progresses.
Still working on tests and textures, not making much headway but still plugging along. Got sidetracked by GitHub actions on a side project. They'll be implemented here eventually
…message system Tests have been updated with thresholds in the package.json file. Tests and the engine itself have been updated to reflect the changes in the message system. These are now passing the basic unit tests and should be good to go in the test project. Working on textures and the IOSystem next.
The IOSystem will use fs to get files from the system. This is going to be tricky to get working as the system uses the message system for loading files and textures. Currently working on getting the scenes loading from the file, but this may take more time to setup than anticipated. Once setup through the message system, json file saves and textures will be loaded from the filesystem in cached memory. Working on getting this setup now BREAKING CHANGE: The tests now hang or fail. Working on resolving this as it's waiting for the message system in other files that is not running and doesn't exist currently
Changed over to ESLint as that is the official supported linter for TypeScript. TSLint has been deprecated and therefore removed
…ngine's message system
Engine has been configured and setup for basic usage. This is a trimmed down version of the initial design, but functional and continues to work.
Fixed a rotation bug. Fixed the collisions to render in place around the object instead of the top corner. Working on implementing zone changing now
I will need to go over components vs behaviours to narrow my focus. There is redundancy in both, and some can extend others. Going to update this after working on some diagrams
This will allow developers to create gui options. Some work is hardcoded for now to be specifically relatedd to the zone file, but things are working for the most part
Now getting constant changes and not using an fps count to determine the frame loop. This can be updated and reviewed later
Welcome to the end game. This is the Alpha version of the Divine Engine. This is the version used in the playable demo Alpha release of (Save the Princess)[https://github.com/srepollock/save-the-princess]. For any issues, please send them under issues in the GitHub project.
srepollock
force-pushed
the
hotfix/postinstall
branch
from
0434896
to
99182d3
Compare
Pull Request Test Coverage Report for Build f0839e6fbf7752c3d350c4bcb58303c802b7c796-PR-90
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.