Componentize UI parts #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search component. The action type chaining may not be ideal.
but keep view in a separate file to avoid cyclic imports. it further gives us the advantage of keeping semantics and UI separate.
Elm handled it well (no runtime errors), but now I’m more cautious to over-engineer this any further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of model, actions, update, view of conceptual UI parts are put in their own file(s). This should make it easier to add more UI parts.
There were some challenges such as having to chain actions from master mailbox to the component's mailbox due to lack of interface types and action composition in Elm (See the
Actiontype insrc/Chronicle/Controller.elm).