Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link report #246

Open
1 of 2 tasks
srid opened this issue Feb 6, 2022 · 5 comments
Open
1 of 2 tasks

Broken link report #246

srid opened this issue Feb 6, 2022 · 5 comments
Labels
enhancement New feature or request plutonomicon

Comments

@srid
Copy link
Owner

srid commented Feb 6, 2022

Add a special page (live server only) that lists all broken links in the notebook.

@srid srid added the enhancement New feature or request label Feb 6, 2022
@srid
Copy link
Owner Author

srid commented Mar 24, 2022

Also if there are broken links, static site generation should fail.

shivaraj-bh pushed a commit to shivaraj-bh/emanote that referenced this issue Dec 18, 2023
@vcavallo
Copy link

This log is a little confusing:

       > [Error#emanote] Found 225 broken links! Emanote generated the site, but the generated site has broken links.
       > [Info#emanote] (Tip: use `--allow-broken-links` to ignore this check.)

for a few reasons:

  • The static site generated actually fails ("Emanote generated the site"...)
  • What is the --allow-broken-links flag and how does one use it?

@srid
Copy link
Owner Author

srid commented Jan 25, 2024

Welcome back @vcavallo

  • The static site generated actually fails ("Emanote generated the site"...)

What do you mean by 'fail'?

  • What is the --allow-broken-links flag and how does one use it?

It will convert this error to a warning, allowing emanote to exit with zero exit code.

emanote --allow-broken-links gen /tmp/output

@vcavallo
Copy link

Hello again, @srid

What do you mean by 'fail'?

I meant an exit code of 1 and no generated site.

emanote --allow-broken-links gen /tmp/output

Yup! that did the trick. I was trying to pass that flag to nix build and not having a good time of it :)

It would be helpful to have that flag option listed in the emanote help.

Thanks!

@vcavallo
Copy link

While I'm here: How would one adjust the .github/workflows/publish.yml step where nix build -j 4 is called in order to allow broken links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plutonomicon
Projects
None yet
Development

No branches or pull requests

2 participants