Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder notes can now live in $folder/index.md #512

Merged
merged 10 commits into from
Feb 10, 2024
Merged

Folder notes can now live in $folder/index.md #512

merged 10 commits into from
Feb 10, 2024

Conversation

srid
Copy link
Owner

@srid srid commented Feb 9, 2024

For #494

  • foo/index.md should be equivalent to foo.md
  • foo/index.yaml should be equivalent to foo.yaml
  • How to deal with broken edit button link for index.md notes?
  • Refactor

@srid srid mentioned this pull request Feb 9, 2024
5 tasks
@srid srid changed the title Index notes Index routes Feb 9, 2024
@srid
Copy link
Owner Author

srid commented Feb 9, 2024

  • How to deal with broken edit button link for index.md notes?

Because, the source-path is now no longer accurate:

image

We can't use encodeRoute anymore - as the information about the index.md slug is lost.

@srid srid marked this pull request as ready for review February 9, 2024 19:10
@srid srid changed the title Index routes Folder notes can now live in $folder/index.md Feb 9, 2024
@srid srid merged commit bb6860b into master Feb 10, 2024
6 checks passed
@srid srid deleted the index-notes branch February 10, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant