Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix template #98

Closed

Conversation

HariAmoor-professional
Copy link
Contributor

Low-hanging fruit for ease of use

We can now nix flake init -t github:srid/haskell-template in the shell and get this template without having to do anything in the browser

@srid
Copy link
Owner

srid commented Apr 8, 2023

What it looks like:

image

Certainly an interesting addition, but I worry about the now even larger flake.nix. Also, the user must manually remove the template from flake.nix as it would serve no purpose in their projects.

If flake templates supported automatic parameter replacement NixOS/nix#4017 (eg: renaming the project, but also removing the template output), I could definitely see a value in having it in here.

@HariAmoor-professional
Copy link
Contributor Author

I worry about the now even larger flake.nix

Large is fine since it's nicely organized, IMO. Is there any reason why you don't like large?

the user must manually remove the template from flake.nix as it would serve no purpose in their projects

Declare it in a flake-module so that the user can comment out the line in the top-level flake where it gets imported?

If flake templates supported automatic parameter replacement NixOS/nix#4017...

I'll see if I have time to tackle it; it might be a while, but I plan to eventually. Until then, I'm leaving this PR open in draft mode.

@srid
Copy link
Owner

srid commented Dec 5, 2023

Gonna close this, since the user can already do git clone https://github.com/srid/haskell-template and get rid of the .git directory for the same effect, without needing us to modify flake.nix.

We can reconsider this if there is tangible value add, such as NixOS/nix#4017

@srid srid closed this Dec 5, 2023
@srid srid mentioned this pull request Jan 12, 2024
@srid
Copy link
Owner

srid commented Jan 12, 2024

@HariAmoor-professional If you are still interested in this, let's do it this way: #120

Otherwise, I'll get to it one day.

@HariAmoor-professional
Copy link
Contributor Author

Never saw you reopen this haha

Get to it yourself, if you can... Don't have much time these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants