Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(website): Add MMark extension to render table with styles #100

Merged
merged 3 commits into from
Apr 14, 2020
Merged

feat(website): Add MMark extension to render table with styles #100

merged 3 commits into from
Apr 14, 2020

Conversation

gillchristian
Copy link
Contributor

@gillchristian gillchristian commented Apr 13, 2020 •
edited

Fixes #91

This PR adds a MMark extension to render tables with classes.

TODO

  • Use Semantic UI classes for cell alignment?
  • ...

Screenshots

Before

Screenshot 2020-04-13 at 19 53 57

After

Screenshot 2020-04-13 at 19 53 42

srid
srid reviewed Apr 13, 2020
View reviewed changes
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic comments, but the main thing I'm wondering is if there is a better way that involves not having to fork mmark's rendering code. In particular I wonder if we can improve something in mmark or mmark-ext to support this ability.

src/Neuron/Zettelkasten/Markdown/Extension.hs Outdated Show resolved Hide resolved
src/Neuron/Zettelkasten/Markdown/Extension.hs Outdated Show resolved Hide resolved
src/Neuron/Zettelkasten/Markdown/Extension.hs Outdated Show resolved Hide resolved
src/Neuron/Zettelkasten/Markdown/Extension.hs Outdated Show resolved Hide resolved
@gillchristian
refactor(pr): Follow project guidelines
8774682 
- better naming
- Relude instead of Prelude
@srid srid mentioned this pull request Apr 13, 2020
Closed
@gillchristian gillchristian requested a review from srid April 14, 2020 20:38
@srid srid merged commit 49c7768 into srid:master Apr 14, 2020
@gillchristian gillchristian deleted the feature/table-styles branch April 14, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid Awaiting requested review from srid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styles questions/suggestions
2 participants
@gillchristian @srid