Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles questions/suggestions #91

Closed
gillchristian opened this issue Apr 12, 2020 · 2 comments · Fixed by #100
Closed

Styles questions/suggestions #91

gillchristian opened this issue Apr 12, 2020 · 2 comments · Fixed by #100
Labels
discussion Forum like question asked; not exactly a feature or a bug.

Comments

@gillchristian
Copy link
Contributor

Are you open to change some of the styles for zettles?

If so, (IMHO) there are some styles that could be improved.

Use Semantic UI classes for tables (ui celled table)

Without the classes:
Screenshot 2020-04-12 at 11 43 51

With the classes:
Screenshot 2020-04-12 at 11 43 34

Full width code blocks

Code blocks with not language take the full with, but the ones with code highlight take 80% (I know this is intentional).

This would be aligned with GitHub styles for code blocks. To me it feels more natural for code blocks to take the full width.

Current:

Screenshot 2020-04-12 at 11 47 25

Proposed:

Screenshot 2020-04-12 at 11 47 45

@gillchristian gillchristian changed the title Styles questions Styles questions/suggestions Apr 12, 2020
@srid
Copy link
Owner

srid commented Apr 12, 2020

Those two suggestions look good to me.

@srid
Copy link
Owner

srid commented Apr 12, 2020

IIUC, using a custom class (like ui celled table) for every table produced by the Markdown parser will require writing an extension. PR welcome.

@srid srid added Web Interface UI related discussion Forum like question asked; not exactly a feature or a bug. and removed Web Interface UI related labels Apr 12, 2020
@srid srid closed this as completed in #100 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Forum like question asked; not exactly a feature or a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants