support append and middlestate #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 20, 2016 20:22
support append and middlestate
update self$2 to self
srijs
requested changes
Nov 24, 2016
| @@ -1 +1,3 @@ | |||
| node_modules | |||
| test/bundle.js | |||
There was a problem hiding this comment.
What's the reason for adding these to the gitignore?
There was a problem hiding this comment.
I'am so sorry. I will remove it, that code is introduced not carefully When test.
| @@ -300,6 +312,69 @@ | |||
| return hex(rawDigest(str).buffer); | |||
| }; | |||
|
|
|||
| this.start = function () { | |||
There was a problem hiding this comment.
I'm wondering whether resetState could be a better name for this method.
There was a problem hiding this comment.
this is a good idea.thanks
| this.getState = function () { | ||
| var turnOffset = self.offset % self.maxChunkLen, | ||
| heap; | ||
| if(!turnOffset){ |
There was a problem hiding this comment.
It would be great if you could adhere to the code style here, and insert spaces before { and (, and after }.
There was a problem hiding this comment.
thanks for your advice, i'll resolve them.
1. Rename method 2. Adhere to the source code style
srijs
approved these changes
Nov 25, 2016
|
Thanks for your contribution! I'll make sure to release a new version as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rusha is the fastest shajs library we used, but the rusha does not support append, one case does not support large files at the same time concurrent computation, resulting in our webworker use is not flexible, so we extend the implementation of append, getState and setState. At present, we use the transformation Library in https://mail.qq.com every day to calculate the total amount of file size of more than 10T.