Skip to content

Commit

Permalink
Update tracer interface (open-telemetry#125)
Browse files Browse the repository at this point in the history
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close open-telemetry#124 open-telemetry#123

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
  • Loading branch information
OlivierAlbertini authored and mayurkale22 committed Jul 24, 2019
1 parent 39ca469 commit c225d84
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions packages/opentelemetry-types/src/trace/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
* limitations under the License.
*/

import { HttpTextFormat } from '../context/propagation/HttpTextFormat';
import { Span } from './span';
import { SpanOptions } from './SpanOptions';
import { BinaryFormat } from '../context/propagation/BinaryFormat';

/**
* Tracer provides an interface for creating {@link Span}s and propagating
Expand Down Expand Up @@ -73,10 +75,8 @@ export interface Tracer {
* Context binary format ({@link BinaryFormat}). For more details see
* <a href="https://w3c.github.io/trace-context-binary/">W3C Trace Context
* binary protocol</a>.
*
* @todo: Change return type once BinaryFormat is available
*/
getBinaryFormat(): unknown;
getBinaryFormat(): BinaryFormat;

/**
* Returns the {@link HttpTextFormat} interface which can inject/extract
Expand All @@ -85,8 +85,6 @@ export interface Tracer {
* If no tracer implementation is provided, this defaults to the W3C Trace
* Context HTTP text format ({@link HttpTraceContext}). For more details see
* <a href="https://w3c.github.io/trace-context/">W3C Trace Context</a>.
*
* @todo: Change return type once HttpTextFormat is available
*/
getHttpTextFormat(): unknown;
getHttpTextFormat(): HttpTextFormat;
}

0 comments on commit c225d84

Please sign in to comment.