Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Add a deferred recover to prevent panics in CI #14

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

srishanbhattarai
Copy link
Owner

Hope this works.

@todo
Copy link

todo bot commented Jul 26, 2018

A hack to prevent panic on CI.

nepcal/main_test.go

Lines 13 to 18 in 33e3313

// TODO: A hack to prevent panic on CI.
defer func() {
if r := recover(); r != nil {
fmt.Println("Recovered in TestRender: ", r)
}
}()


This comment was generated by todo based on a TODO comment in 33e3313 in #14. cc @srishanbhattarai.

@srishanbhattarai srishanbhattarai merged commit 12f3959 into master Jul 26, 2018
@todo todo bot mentioned this pull request Jul 26, 2018
@srishanbhattarai srishanbhattarai deleted the panic-fix branch July 26, 2018 04:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 89

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.458%

Totals Coverage Status
Change from base Build 86: 0.0%
Covered Lines: 115
Relevant Lines: 118

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants