Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highly experimental gRPC implementation #16

Closed
wants to merge 1 commit into from

Conversation

srishanbhattarai
Copy link
Owner

No description provided.

@todo
Copy link

todo bot commented Aug 21, 2018

Change the package so that it returns the grpc server rather than being a main p...

nepcal/api/main.go

Lines 23 to 28 in d8ec188

// TODO: Change the package so that it returns the grpc server rather than being a main package itself.
func main() {
server := grpc.NewServer()
api := api{
converter: dateconv.Converter{},


This comment was generated by todo based on a TODO comment in d8ec188 in #16. cc @srishanbhattarai.

@srishanbhattarai srishanbhattarai changed the title Highly experimental grpc implementation Highly experimental gRPC implementation Aug 21, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 110

  • 42 of 183 (22.95%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-28.3%) to 58.881%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dateconv/dateconv.go 0 9 0.0%
api/api.go 22 33 66.67%
cli.go 6 20 30.0%
api/main.go 3 20 15.0%
api/proto/api.pb.go 10 100 10.0%
Files with Coverage Reduction New Missed Lines %
main.go 2 96.34%
Totals Coverage Status
Change from base Build 108: -28.3%
Covered Lines: 242
Relevant Lines: 411

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants