Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root ssh directive for cRPD #1966

Closed
nzjc opened this issue Apr 2, 2024 · 0 comments · Fixed by #1967
Closed

root ssh directive for cRPD #1966

nzjc opened this issue Apr 2, 2024 · 0 comments · Fixed by #1967
Assignees
Labels
enhancement New feature or request

Comments

@nzjc
Copy link

nzjc commented Apr 2, 2024

Currently the template in containerlab/nodes/crpd/crpd.cfg doesn't specify root-login allow, which means despite the root login being configured, you can't SSH in as root.

This is on cRPD 23.x (tested today)

I would suggest adding this to the template:

system {
    services {
        ssh {
            root-login allow;
        }
    }
}

the version stanza can be removed as it it automatically applied by junos on commit

steiler added a commit that referenced this issue Apr 2, 2024
@steiler steiler self-assigned this Apr 2, 2024
@steiler steiler added the enhancement New feature or request label Apr 2, 2024
hellt added a commit that referenced this issue Apr 2, 2024
* cRPD: allow root ssh directive

fixing: #1966

* remove version from the config template

---------

Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
@steiler steiler linked a pull request Apr 2, 2024 that will close this issue
@steiler steiler closed this as completed Apr 2, 2024
hellt added a commit to mzagozen/containerlab that referenced this issue Apr 3, 2024
* cRPD: allow root ssh directive

fixing: srl-labs#1966

* remove version from the config template

---------

Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
hellt added a commit that referenced this issue Apr 3, 2024
* Add vr-c8000v kind

This is right now a verbatim copy of the existing vr-csr kind. I expect
they will diverge in the future though, so it is best to create a copy
now rather than encourage branching logic in the same file.

* Bump github.com/containers/podman/v4 from 4.9.3 to 4.9.4 (#1964)

Bumps [github.com/containers/podman/v4](https://github.com/containers/podman) from 4.9.3 to 4.9.4.
- [Release notes](https://github.com/containers/podman/releases)
- [Changelog](https://github.com/containers/podman/blob/v4.9.4/RELEASE_NOTES.md)
- [Commits](containers/podman@v4.9.3...v4.9.4)

---
updated-dependencies:
- dependency-name: github.com/containers/podman/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* cRPD: allow root ssh directive (#1967)

* cRPD: allow root ssh directive

fixing: #1966

* remove version from the config template

---------

Co-authored-by: Roman Dodin <dodin.roman@gmail.com>

* Bump go to 1.21 (#1970)

* bump go to 1.21

* change vmx link

* fix another dead link

* remove empty file

* added envrc file

* added c8000v docs

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Markus Vahlenkamp <github@vahlenkamp.net>
Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants