Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cRPD: allow root ssh directive #1967

Merged
merged 2 commits into from
Apr 2, 2024
Merged

cRPD: allow root ssh directive #1967

merged 2 commits into from
Apr 2, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Apr 2, 2024

fixing: #1966

@steiler steiler requested a review from hellt April 2, 2024 06:37
@steiler steiler added the enhancement New feature or request label Apr 2, 2024
@steiler steiler self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.78%. Comparing base (c0f4a74) to head (856424b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   53.82%   53.78%   -0.05%     
==========================================
  Files         159      159              
  Lines       11492    11492              
==========================================
- Hits         6186     6181       -5     
- Misses       4445     4449       +4     
- Partials      861      862       +1     

see 1 file with indirect coverage changes

@hellt hellt merged commit 6a0dff2 into main Apr 2, 2024
6 of 7 checks passed
@hellt hellt deleted the crpdsshrootallow branch April 2, 2024 07:25
@steiler steiler linked an issue Apr 2, 2024 that may be closed by this pull request
hellt added a commit to mzagozen/containerlab that referenced this pull request Apr 3, 2024
* cRPD: allow root ssh directive

fixing: srl-labs#1966

* remove version from the config template

---------

Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
hellt added a commit that referenced this pull request Apr 3, 2024
* Add vr-c8000v kind

This is right now a verbatim copy of the existing vr-csr kind. I expect
they will diverge in the future though, so it is best to create a copy
now rather than encourage branching logic in the same file.

* Bump github.com/containers/podman/v4 from 4.9.3 to 4.9.4 (#1964)

Bumps [github.com/containers/podman/v4](https://github.com/containers/podman) from 4.9.3 to 4.9.4.
- [Release notes](https://github.com/containers/podman/releases)
- [Changelog](https://github.com/containers/podman/blob/v4.9.4/RELEASE_NOTES.md)
- [Commits](containers/podman@v4.9.3...v4.9.4)

---
updated-dependencies:
- dependency-name: github.com/containers/podman/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* cRPD: allow root ssh directive (#1967)

* cRPD: allow root ssh directive

fixing: #1966

* remove version from the config template

---------

Co-authored-by: Roman Dodin <dodin.roman@gmail.com>

* Bump go to 1.21 (#1970)

* bump go to 1.21

* change vmx link

* fix another dead link

* remove empty file

* added envrc file

* added c8000v docs

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Markus Vahlenkamp <github@vahlenkamp.net>
Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root ssh directive for cRPD
2 participants