Add "auto" option to ipv4-subnet and ipv6-subnet #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @mzagozen Let me know if that seems OK to you and we can merge |
If we do not care about the assigned IPv4/IPv6 subnet for the container network, we let the container runtime allocate one for us. This guarantees to avoid a collision of the hardcoded range (172.20.20.0/24 and 2001:172:20:20::/64) with any existing container networks. This just works for the podman runtime. For the docker runtime we compute the IPv6 subnet manually because it can only pick addresses from the configured (global) subnet.
|
Agree on the docs and refactoring. I pushed another rebased branch to fix the diff in the GitHub UI. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
==========================================
- Coverage 53.90% 53.77% -0.13%
==========================================
Files 159 160 +1
Lines 11486 11504 +18
==========================================
- Hits 6191 6186 -5
- Misses 4433 4452 +19
- Partials 862 866 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not care about the assigned IPv4/IPv6 subnet for the container network, we let the container runtime allocate one for us. This guarantees to avoid a collision of the hardcoded range (172.20.20.0/24 and 2001:172:20:20::/64) with any existing container networks. For example this makes it possible to run concurrent isolated topologies without directly modifying the topology files.
This just works for the podman runtime. For the docker runtime we compute the IPv6 subnet manually because it can only pick addresses from the configured (global) subnet.