Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux VM kind #1976

Merged
merged 6 commits into from
Jun 9, 2024
Merged

Add Linux VM kind #1976

merged 6 commits into from
Jun 9, 2024

Conversation

jmussmann
Copy link
Contributor

This PR add support for a vrnlab linux VM kind.

The corresponding PR in the vrnetlab repository is "Add Ubuntu Support #183" for ubuntu.

The code would also support other linux distribution. This is why the kind is called vr_linux and not vr_ubuntu.

@hellt
Copy link
Member

hellt commented Jun 8, 2024

I plan to review/merge this in the coming days

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 53.72%. Comparing base (9ecdf0e) to head (602d660).
Report is 51 commits behind head on main.

Current head 602d660 differs from pull request most recent head 336eec1

Please upload reports for the commit 336eec1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   53.58%   53.72%   +0.13%     
==========================================
  Files         160      163       +3     
  Lines       11536    11631      +95     
==========================================
+ Hits         6182     6249      +67     
- Misses       4489     4507      +18     
- Partials      865      875      +10     
Files Coverage Δ
clab/register.go 100.00% <100.00%> (ø)
nodes/generic_vm/generic_vm.go 3.22% <3.22%> (ø)

... and 22 files with indirect coverage changes

@hellt hellt merged commit 49f6ece into srl-labs:main Jun 9, 2024
58 checks passed
@hellt
Copy link
Member

hellt commented Jun 9, 2024

thanks @jmussmann !
both this and hellt/vrnetlab#198 have been merged. Appreciate your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants