Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knob to skip adding extended ACL to labdir #2028

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add knob to skip adding extended ACL to labdir #2028

merged 3 commits into from
Apr 29, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Apr 29, 2024

This PR adds the "--skip-labdir-acl" knob to the deploy call. Setting it will skip adding extended ACL to the lab dir.

This PR adds the "--skip-labdir-acl" knob to the deploy call. Setting it will skip adding extended ACL to the lab dir.
@steiler steiler requested a review from hellt April 29, 2024 12:00
@steiler
Copy link
Collaborator Author

steiler commented Apr 29, 2024

@hellt can you maybe add a quick test. THX

@steiler steiler linked an issue Apr 29, 2024 that may be closed by this pull request
@steiler steiler added the enhancement New feature or request label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.78%. Comparing base (efbba05) to head (d3bf58f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
+ Coverage   53.72%   53.78%   +0.06%     
==========================================
  Files         160      160              
  Lines       11515    11521       +6     
==========================================
+ Hits         6186     6197      +11     
+ Misses       4463     4459       -4     
+ Partials      866      865       -1     
Files Coverage Δ
clab/deploy_options.go 66.66% <100.00%> (+2.38%) ⬆️
cmd/deploy.go 79.16% <100.00%> (+0.59%) ⬆️
clab/clab.go 70.27% <50.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@hellt
Copy link
Member

hellt commented Apr 29, 2024

thanks for the quick turnover @steiler!
I tested locally and it works as advertised. didn't add tests though, just added the flag to one of the deployments so that we know it doesn't break things

@hellt hellt merged commit f753f6b into main Apr 29, 2024
63 checks passed
@hellt hellt deleted the skipACLKnob branch April 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable file acls (facl)
2 participants