Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user's home directory when fetching the docker config #2135

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Jul 9, 2024

fix #2079

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (17758ab) to head (c637943).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2135      +/-   ##
==========================================
- Coverage   53.48%   53.45%   -0.04%     
==========================================
  Files         168      168              
  Lines       11919    11913       -6     
==========================================
- Hits         6375     6368       -7     
- Misses       4656     4658       +2     
+ Partials      888      887       -1     
Files Coverage Δ
runtime/docker/auth.go 83.92% <100.00%> (+4.89%) ⬆️
utils/file.go 58.68% <ø> (ø)

... and 1 file with indirect coverage changes

@hellt hellt merged commit f0d39b3 into main Jul 9, 2024
63 of 64 checks passed
@hellt hellt deleted the sudo-docker-config branch July 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A docker config from the root user is read when using sudo without -E flag
1 participant