Include OS version info in metadata #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickeydan
requested changes
May 28, 2022
trickeydan
added a commit
that referenced
this pull request
May 28, 2022
This change usings the string.Template templating engine to allow metadata to be inserted into the initial log lines at runtime. This means that we can print the OS version and other information that Astoria is aware of in the log lines. It should be noted that the metadata is the metadata at the time of the log being generated, so the arena, zone and other keys that may be updated by a metadata USB might not be accurate when the code first starts. This is because metadata USBs are often inserted after the robot has been turned on! Fixes #156 This change also builds the path to #113, although doesn't resolve it until #163 is also merged.
Co-authored-by: Dan Trickey <git@trickey.io>
trickeydan
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126