-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for SR2024 image #212
base: main
Are you sure you want to change the base?
Conversation
Disallow explicit any forces the type ignore to be needed
Seems to have strange issues when building docs Update depreciations in CI actions
fsync flushes OS buffers to disk.
Make log files sync to disk
@@ -110,7 +111,7 @@ async def run_process(self) -> None: | |||
) | |||
self._process_end_event.clear() | |||
self._process = await asyncio.create_subprocess_exec( | |||
"python3", | |||
sys.executable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very neat way of handling this.
@@ -207,6 +208,7 @@ def log( | |||
) -> None: | |||
fh.write(data) | |||
fh.flush() | |||
fsync(fh.fileno()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this, we had too many issues with logs not being synced to disk.
tasks = [asyncio.gather( | ||
*(event.wait() for event in self._dependency_events.values()), | ||
)] | ||
tasks: List[Union[asyncio.Future[Any], asyncio.Task[Any]]] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should this Union
simply be Awaitable
?
Due to the large number of changes added to main since the 0.11.0 release this branch starts at the release tag and the 0.11.2 release will be directly from this branch to minimise the amount of new code that needs testing.
sys.executable
for the usercode process so the same python is usedtomli
so it is installed with Python 3.10.5/etc/srobo-release
and fall-back to/etc/os-release
to allow for custom OS names without affecting the OS