Fixes for SR2024 image #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow explicit any forces the type ignore to be needed
Seems to have strange issues when building docs Update depreciations in CI actions
RealOrangeOne
approved these changes
Sep 5, 2023
fsync flushes OS buffers to disk.
Make log files sync to disk
raccube
reviewed
Jul 6, 2024
| @@ -110,7 +111,7 @@ async def run_process(self) -> None: | |||
| ) | |||
| self._process_end_event.clear() | |||
| self._process = await asyncio.create_subprocess_exec( | |||
| "python3", | |||
| sys.executable, | |||
There was a problem hiding this comment.
This is a very neat way of handling this.
raccube
reviewed
Jul 6, 2024
| @@ -207,6 +208,7 @@ def log( | |||
| ) -> None: | |||
| fh.write(data) | |||
| fh.flush() | |||
| fsync(fh.fileno()) | |||
There was a problem hiding this comment.
Thank you for adding this, we had too many issues with logs not being synced to disk.
raccube
approved these changes
Jul 6, 2024
| tasks = [asyncio.gather( | ||
| *(event.wait() for event in self._dependency_events.values()), | ||
| )] | ||
| tasks: List[Union[asyncio.Future[Any], asyncio.Task[Any]]] = [ |
There was a problem hiding this comment.
Question: Should this Union simply be Awaitable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the large number of changes added to main since the 0.11.0 release this branch starts at the release tag and the 0.11.2 release will be directly from this branch to minimise the amount of new code that needs testing.
sys.executablefor the usercode process so the same python is usedtomliso it is installed with Python 3.10.5/etc/srobo-releaseand fall-back to/etc/os-releaseto allow for custom OS names without affecting the OS