Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Remove the serial handler decorator #513

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

trickeydan
Copy link
Contributor

Fixes #448

@trickeydan trickeydan force-pushed the remove-serial-handler-decorator branch from d59e967 to d892f6a Compare January 27, 2020 20:05
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2020

Code Climate has analyzed commit 5f30758 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 67.2% (95% is the threshold).

This pull request will bring the total coverage in the repository to 89.0% (-0.9% change).

View more on Code Climate.

@trickeydan
Copy link
Contributor Author

Many of the type: ignore statements that are added in this PR are due to #489

Copy link
Contributor

@kierdavis kierdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a context manager would do a better job of reducing the duplicated try..except blocks without breaking typing like decorators do...

For now, this is good (and has been needed for a long time). Thanks!

@trickeydan trickeydan merged commit 54ddd3f into master Jan 28, 2020
@trickeydan trickeydan deleted the remove-serial-handler-decorator branch January 28, 2020 09:35
@trickeydan
Copy link
Contributor Author

I wonder if a context manager would do a better job of reducing the duplicated try..except blocks without breaking typing like decorators do...

Context Managers would definitely circumvent the issues with typing that decorators suffer from. I think we should investigate this is the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace handle_serial_error
2 participants