This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Add Backend as superclass of SerialHardwareBackend #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted by @sersorrel in srobo/sr-robot3#2 (comment) This also means that the abstract methods are now actually enforced. We should consider introducing a run-time type check for this, but I am unable to think of a good place to put it at the moment.
trickeydan
added
typing
|
Code Climate has analyzed commit 4e36306 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.0% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @sersorrel in srobo/sr-robot3#2 (comment)
This also means that the abstract methods are now actually enforced.
We should consider introducing a run-time type check for this, but I am
unable to think of a good place to put it at the moment.
Checklist
semver-major,semver-minororsemver-patchlabel as appropriateWhy do you want to make these changes?
Stops need to cast to
Type[Backend]in environment definitions.Which parts of the codebase do your changes affect?
SerialHardwareBackendand subclasses thereof,SRV4MotorBoardBackend,SBArduinoHardwareBackendHow do your changes affect student or volunteer experience?
Shouldn't make any difference. This is purely for typing
Are your changes related to any existing issues or PRs? How so?
We had previously attributed this bug to #489, although didn't have an open issue for it :/