Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up to date #1

Merged
merged 8 commits into from
Mar 10, 2019
Merged

Bring up to date #1

merged 8 commits into from
Mar 10, 2019

Conversation

RealOrangeOne
Copy link
Member

@RealOrangeOne RealOrangeOne commented Mar 3, 2019

Update the media consent form as required in srobo/tasks#187.

Each commit is atomic, and contains the notable changes.

@RealOrangeOne
Copy link
Member Author

This PR has, in its current state, been reviewed and approved by the trustees.

@PeterJCLaw
Copy link
Member

This PR has, in its current state, been reviewed and approved by the trustees.

Cool. Just to be extra clear on this: that includes the consent age being 16?

@@ -3,14 +3,10 @@ all: form.pdf
%.pdf: %.svg
inkscape -A $@ $<

marketing/logos:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this target?
I appreciate that the submodule has changed, however I still think it's useful to have a target of this form.


[![CircleCI](https://circleci.com/gh/srobo/media-consent.svg?style=svg)](https://circleci.com/gh/srobo/media-consent)

PDFs can be downloaded from the 'Artifacts' tab in CircleCI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tab only shows up if you're logged in. Is this expected? Should we note this?
For this repo I think it's fine if the artefacts are public, though I don't think it's a big deal (a comment here would suffice for now IMO).

@PeterJCLaw
Copy link
Member

Once merged, please could you also update the media-consent-access repo as well.

@RealOrangeOne
Copy link
Member Author

This PR has, in its current state, been reviewed and approved by the trustees.

Cool. Just to be extra clear on this: that includes the consent age being 16?

Correct

@RealOrangeOne RealOrangeOne merged commit bd9a60c into master Mar 10, 2019
@RealOrangeOne RealOrangeOne deleted the update-2019 branch March 10, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants