Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html-minifier): use public folder with $1 #746

Merged
merged 3 commits into from
Nov 1, 2019

Conversation

srod
Copy link
Owner

@srod srod commented Aug 12, 2019

No description provided.

@srod srod self-assigned this Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #746 into develop will decrease coverage by 0.25%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
- Coverage     99.2%   98.94%   -0.26%     
===========================================
  Files           21       21              
  Lines          376      379       +3     
  Branches        79       80       +1     
===========================================
+ Hits           373      375       +2     
- Misses           3        4       +1
Impacted Files Coverage Δ
packages/core/src/setup.js 100% <100%> (ø) ⬆️
packages/utils/src/utils.js 97.61% <75%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edfae3...67975e2. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #746 into develop will decrease coverage by 0.76%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
- Coverage     99.2%   98.43%   -0.77%     
===========================================
  Files           21       21              
  Lines          376      383       +7     
  Branches        79       82       +3     
===========================================
+ Hits           373      377       +4     
- Misses           3        6       +3
Impacted Files Coverage Δ
packages/core/src/setup.js 100% <100%> (ø) ⬆️
packages/core/src/compress.js 94.87% <60%> (-5.13%) ⬇️
packages/utils/src/utils.js 97.61% <75%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cd892...0b5dc89. Read the comment docs.

@srod srod force-pushed the fix-html-minifier-public-folder branch from 985b066 to e3c2bc9 Compare November 1, 2019 16:30
@srod srod force-pushed the fix-html-minifier-public-folder branch from e3c2bc9 to 0b5dc89 Compare November 1, 2019 16:34
@srod srod merged commit cc246ba into develop Nov 1, 2019
@srod srod deleted the fix-html-minifier-public-folder branch November 1, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant