Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pop up message to bibl[ptr]/citedRange/@unit="entry" #316

Closed
davidamichelson opened this issue May 14, 2024 · 4 comments
Closed

Add a pop up message to bibl[ptr]/citedRange/@unit="entry" #316

davidamichelson opened this issue May 14, 2024 · 4 comments
Assignees
@wsalesky

Comments

@davidamichelson
Copy link
Contributor

davidamichelson commented May 14, 2024 •
edited
Loading

@wsalesky When we have bibl[ptr]/citedRange/@Unit="entry" please make the text node value of citedRange look like a live URL (blue or whatever) and when clicked on have a pop up message display that says: "This entry number is from Wright's printed catalogue. Due to renumbering, Wright's entry numbers do not match the numbering used in this digital catalogue."
@davidamichelson davidamichelson self-assigned this May 14, 2024
@wsalesky
Copy link
Collaborator

@davidamichelson what should the popup say?

@davidamichelson
Copy link
Contributor Author

Sorry, here you go!

@davidamichelson
Copy link
Contributor Author

@wsalesky Sorry I changed it again

@wlpotter wlpotter assigned wsalesky and unassigned davidamichelson May 24, 2024
wsalesky added a commit that referenced this issue May 27, 2024
@wsalesky
Updates to citedRange display #316
dc56949
wsalesky added a commit that referenced this issue May 27, 2024
@wsalesky
Merge pull request #325 from srophe/issue316a
126ae59 
Updates to citedRange display #316
@wsalesky
Copy link
Collaborator

Fixed

wsalesky added a commit that referenced this issue May 27, 2024
@wsalesky
Updates
15e3ed5 
Updates include fixes for: 
#316
#319
#311
#310
@wsalesky wsalesky mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsalesky wsalesky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsalesky @davidamichelson