Issue #1221 #1223
Merged
Issue #1221 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidamichelson I'm not sure how to review this when there are two reviewers (I'm guessing Winona should actually merge the pull request). It looks good to me though. |
|
Yep, this is for Winona, just wanted you to know about.
…On Thu, Jun 18, 2020 at 11:13 AM Daniel Schwartz ***@***.***> wrote:
@davidamichelson <https://github.com/davidamichelson> I'm not sure how to
review this when there are two reviewers (I'm guessing Winona should
actually merge the pull request). It looks good to me though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1223 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXQ37JEVVIC66XAGOD6KN3RXI4IZANCNFSM4OBAZVZA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dynamic linking of icons for e-GEDSH URLS
@wsalesky Look, I updated the app! I did not know if I should use the e-gedsh.png or the e-gedsh favicon, hopefully the png is the correct one. Would you please check my work?
Thanks!
Fixes Issue #1221