Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17.0.1 #341

Merged
merged 6 commits into from Nov 22, 2019
Merged

v1.17.0.1 #341

merged 6 commits into from Nov 22, 2019

Conversation

srz-zumix
Copy link
Owner

No description provided.

Copy link

@typot typot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from typot

@@ -4,6 +4,13 @@

## Changes for 1.17.0

* New
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"*" at 7 is typo?

  • e
  • s
  • i
  • a
  • n

@@ -4,6 +4,13 @@

## Changes for 1.17.0

* New
* GTEST_SKIP 対応
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"*" at 8 is typo?

  • e
  • s
  • i
  • a
  • n

@@ -4,6 +4,13 @@

## Changes for 1.17.0

* New
* GTEST_SKIP 対応
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"対応" at 8 is typo?

@@ -4,6 +4,13 @@

## Changes for 1.17.0

* New
* GTEST_SKIP 対応
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GTEST_SKIP" at 8 is typo?

  • POSTSCRIPT
  • CITYSCAPE

* New
* GTEST_SKIP 対応

--------------------------------------------------
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"--------------------------------------------------" at 10 is typo?


--------------------------------------------------

## Changes for 1.17.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"##" at 12 is typo?

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #341 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   96.12%   96.12%   +<.01%     
==========================================
  Files         210      210              
  Lines       10378    10384       +6     
==========================================
+ Hits         9976     9982       +6     
  Misses        402      402
Impacted Files Coverage Δ
test/syntax_gtest_tests.cpp 95.93% <100%> (+0.03%) ⬆️
test/syntax_tests.cpp 96.13% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7d178...fe2a3ec. Read the comment docs.

@srz-zumix srz-zumix merged commit 0a5f814 into master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant