New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editorconfig lint #390
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #390 +/- ##
=======================================
Coverage 96.7% 96.7%
=======================================
Files 210 210
Lines 10532 10532
=======================================
Hits 10185 10185
Misses 347 347
Continue to review full report at Codecov.
|
// MFC を初期化して、エラーの場合は結果を印刷します。 | ||
if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0)) | ||
{ | ||
// TODO: 必要に応じてエラー コードを変更してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
} | ||
else | ||
{ | ||
// TODO: アプリケーションの動作を記述するコードをここに挿入してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
} | ||
else | ||
{ | ||
// TODO: 必要に応じてエラー コードを変更してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
} | ||
else | ||
{ | ||
// TODO: 蠢�ヲ√↓蠢懊§縺ヲ繧ィ繝ゥ繝シ 繧ウ繝シ繝峨r螟画峩縺励※縺上□縺輔>縲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)
Rule | Confidence |
---|---|
readability/todo |
2 |
You can mark this issue as closed if you should not tackle it. (see our document about issues)
|
} | ||
else | ||
{ | ||
// TODO: 繧「繝励Μ繧ア繝シ繧キ繝ァ繝ウ縺ョ蜍穂ス懊r險倩ソー縺吶k繧ウ繝シ繝峨r縺薙%縺ォ謖ソ蜈・縺励※縺上□縺輔>縲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)
Rule | Confidence |
---|---|
readability/todo |
2 |
You can mark this issue as closed if you should not tackle it. (see our document about issues)
// MFC 繧貞�譛溷喧縺励※縲√お繝ゥ繝シ縺ョ蝣エ蜷医�邨先棡繧貞魂蛻キ縺励∪縺吶 | ||
if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0)) | ||
{ | ||
// TODO: 蠢�ヲ√↓蠢懊§縺ヲ繧ィ繝ゥ繝シ 繧ウ繝シ繝峨r螟画峩縺励※縺上□縺輔>縲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)
Rule | Confidence |
---|---|
readability/todo |
2 |
You can mark this issue as closed if you should not tackle it. (see our document about issues)
@@ -26,24 +26,24 @@ int _tmain(int argc, TCHAR* argv[], TCHAR* envp[]) | |||
|
|||
if (hModule != NULL) | |||
{ | |||
// MFC ����āA�G���[�̏ꍇ�͌��ʂ���܂��B | |||
// MFC を初期化して、エラーの場合は結果を印刷します。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0)) | ||
{ | ||
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B | ||
_tprintf(_T("�v���I�ȃG���[: MFC �̏����ł��܂���ł����B\n")); | ||
// TODO: 必要に応じてエラー コードを変更してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B | ||
_tprintf(_T("�v���I�ȃG���[: MFC �̏����ł��܂���ł����B\n")); | ||
// TODO: 必要に応じてエラー コードを変更してください。 | ||
_tprintf(_T("致命的なエラー: MFC の初期化ができませんでした。\n")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
nRetCode = 1; | ||
} | ||
else | ||
{ | ||
// TODO: �A�v���P�[�V�����̓����L�q����R�[�h����ɑ}��Ă��������B | ||
// TODO: アプリケーションの動作を記述するコードをここに挿入してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
IUTEST_INIT(&argc, argv); | ||
nRetCode = IUTEST_RUN_ALL_TESTS(); | ||
} | ||
} | ||
else | ||
{ | ||
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B | ||
_tprintf(_T("�v���I�ȃG���[: GetModuleHandle �����s���܂���\n")); | ||
// TODO: 必要に応じてエラー コードを変更してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B | ||
_tprintf(_T("�v���I�ȃG���[: GetModuleHandle �����s���܂���\n")); | ||
// TODO: 必要に応じてエラー コードを変更してください。 | ||
_tprintf(_T("致命的なエラー: GetModuleHandle が失敗しました\n")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]
cpplint detected 10 issues on the commit 92a6467. |
|
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in 9795f86
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in d5e1c5d
|
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in ccedea3
|
|
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in 7665205
|
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in c4cd220
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in 5f66342
|
|
|
iutest/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c Line 1 in e173461
|
cpplint detected 11 issues on the commit 1c154ce. |
No description provided.