Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editorconfig lint #390

Merged
merged 44 commits into from Mar 22, 2020
Merged

fix: editorconfig lint #390

merged 44 commits into from Mar 22, 2020

Conversation

srz-zumix
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #390 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #390   +/-   ##
=======================================
  Coverage     96.7%   96.7%           
=======================================
  Files          210     210           
  Lines        10532   10532           
=======================================
  Hits         10185   10185           
  Misses         347     347
Impacted Files Coverage Δ
test/cxx_feature_tests.cpp 91.25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d926f3...e72f342. Read the comment docs.

// MFC を初期化して、エラーの場合は結果を印刷します。
if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0))
{
// TODO: 必要に応じてエラー コードを変更してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

}
else
{
// TODO: アプリケーションの動作を記述するコードをここに挿入してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

}
else
{
// TODO: 必要に応じてエラー コードを変更してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

}
else
{
// TODO: 蠢�ヲ√↓蠢懊§縺ヲ繧ィ繝ゥ繝シ 繧ウ繝シ繝峨r螟画峩縺励※縺上□縺輔>縲
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)

Rule Confidence
readability/todo 2

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 10, 2020

// iutest_mfc_sample.cpp : コンソール アプリケーションのエントリ ポイントを定義します。

[cpplint] No copyright message found. You should have a line: "Copyright [year] " (view)

Rule Confidence
legal/copyright 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

}
else
{
// TODO: 繧「繝励Μ繧ア繝シ繧キ繝ァ繝ウ縺ョ蜍穂ス懊r險倩ソー縺吶k繧ウ繝シ繝峨r縺薙%縺ォ謖ソ蜈・縺励※縺上□縺輔>縲
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)

Rule Confidence
readability/todo 2

You can mark this issue as closed if you should not tackle it. (see our document about issues)

// MFC 繧貞�譛溷喧縺励※縲√お繝ゥ繝シ縺ョ蝣エ蜷医�邨先棡繧貞魂蛻キ縺励∪縺吶
if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0))
{
// TODO: 蠢�ヲ√↓蠢懊§縺ヲ繧ィ繝ゥ繝シ 繧ウ繝シ繝峨r螟画峩縺励※縺上□縺輔>縲
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] Missing username in TODO; it should look like "// TODO(my_username): Stuff." (view)

Rule Confidence
readability/todo 2

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@@ -26,24 +26,24 @@ int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])

if (hModule != NULL)
{
// MFC ����āA�G���[�̏ꍇ�͌��ʂ���܂��B
// MFC を初期化して、エラーの場合は結果を印刷します。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

if (!AfxWinInit(hModule, NULL, ::GetCommandLine(), 0))
{
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B
_tprintf(_T("�v���I�ȃG���[: MFC �̏����ł��܂���ł����B\n"));
// TODO: 必要に応じてエラー コードを変更してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B
_tprintf(_T("�v���I�ȃG���[: MFC �̏����ł��܂���ł����B\n"));
// TODO: 必要に応じてエラー コードを変更してください。
_tprintf(_T("致命的なエラー: MFC の初期化ができませんでした。\n"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

nRetCode = 1;
}
else
{
// TODO: �A�v���P�[�V�����̓����L�q����R�[�h����ɑ}��Ă��������B
// TODO: アプリケーションの動作を記述するコードをここに挿入してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

IUTEST_INIT(&argc, argv);
nRetCode = IUTEST_RUN_ALL_TESTS();
}
}
else
{
// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B
_tprintf(_T("�v���I�ȃG���[: GetModuleHandle �����s���܂���\n"));
// TODO: 必要に応じてエラー コードを変更してください。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

// TODO: �K�v�ɉ����ăG���[ �R�[�h��ύX���Ă��������B
_tprintf(_T("�v���I�ȃG���[: GetModuleHandle �����s���܂���\n"));
// TODO: 必要に応じてエラー コードを変更してください。
_tprintf(_T("致命的なエラー: GetModuleHandle が失敗しました\n"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Tab found; better to use spaces [whitespace/tab] [1]

@ghost
Copy link

ghost commented Mar 10, 2020

cpplint detected 10 issues on the commit 92a6467.
Visit the analysis result to review all issues.

@ghost
Copy link

ghost commented Mar 17, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200317_7_1GN8RPO_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 17, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200317_6_12841GC_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 17, 2020

[cpplint] /tmp/d20200317-6-12841gc/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200317-6-12841gc/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 18, 2020

[cpplint] /tmp/d20200318-6-yhbqo5/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200318-6-yhbqo5/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 18, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200318_6_YHBQO5_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] /tmp/d20200319-6-i8j2qe/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200319-6-i8j2qe/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200319_6_I8J2QE_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200319_6_ZWKDUR_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] /tmp/d20200319-6-zwkdur/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200319-6-zwkdur/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200319_7_1Z6Q3U_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] /tmp/d20200319-7-1z6q3u/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200319-7-1z6q3u/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] /tmp/d20200319-7-z5s00l/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200319-7-z5s00l/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 19, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200319_7_Z5S00L_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 20, 2020

[cpplint] No #ifndef header guard found, suggested CPP variable is: TMP_D20200320_6_1SCPLJD_PROJECTS_VS2017_ANDROID_IUTEST_ANDROID_NATIVEACTIVITY_PCH_H (view)

Rule Confidence
build/header_guard 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 20, 2020

[cpplint] /tmp/d20200320-6-1scpljd/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.c should include its header file /tmp/d20200320-6-1scpljd/projects/vs2017/android/iutest_android.NativeActivity/android_native_app_glue.h (view)

Rule Confidence
build/include 5

You can mark this issue as closed if you should not tackle it. (see our document about issues)

@ghost
Copy link

ghost commented Mar 21, 2020

cpplint detected 11 issues on the commit 1c154ce.
Visit the analysis result to review all issues.

@srz-zumix srz-zumix merged commit bebdf36 into develop Mar 22, 2020
@srz-zumix srz-zumix deleted the feature/fix_editorconfig_lint branch March 22, 2020 07:57
@srz-zumix srz-zumix added the CI label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant