Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install script #411

Merged
merged 11 commits into from Apr 13, 2020
Merged

update install script #411

merged 11 commits into from Apr 13, 2020

Conversation

srz-zumix
Copy link
Owner

No description provided.

set -e

if [ -z ${CLANG_VERSION+x} ]; then
echo "CLANG_VERSOIN is empty. skip install clang..."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Misspell] "VERSOIN" is a misspelling of "VERSION" (view)

Rule
"VERSOIN" is a misspelling of "VERSION"

You can mark this issue as closed if you should not tackle it. (see our document about issues)


. /etc/os-release
wget -qO - http://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
add-apt-repository -y 'deb http://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${CLANG_VERSION} main'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

wget -qO - http://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
add-apt-repository -y 'deb http://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${CLANG_VERSION} main'
apt-get -y --allow-unauthenticated update
apt-get -qq install clang-${CLANG_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086



if $INSATLL_CLANG_TOOLS; then
apt-get -y --force-yes -qq install clang-$CLANG_VERSION clang-tools-$CLANG_VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086



if $INSATLL_CLANG_TOOLS; then
apt-get -y --force-yes -qq install clang-$CLANG_VERSION clang-tools-$CLANG_VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

fi

update-alternatives --install /usr/bin/clang clang \
/usr/bin/clang-${CLANG_VERSION} 360 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086


update-alternatives --install /usr/bin/clang clang \
/usr/bin/clang-${CLANG_VERSION} 360 \
--slave /usr/bin/clang++ clang++ /usr/bin/clang++-${CLANG_VERSION} \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

update-alternatives --install /usr/bin/clang clang \
/usr/bin/clang-${CLANG_VERSION} 360 \
--slave /usr/bin/clang++ clang++ /usr/bin/clang++-${CLANG_VERSION} \
${CLANG_SLAVES}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086


add-apt-repository -y ppa:ubuntu-toolchain-r/test
apt-get -y --allow-unauthenticated update
apt-get -qq install g++-${GCC_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

apt-get -y --allow-unauthenticated update
apt-get -qq install g++-${GCC_VERSION}
update-alternatives --install /usr/bin/gcc gcc \
/usr/bin/gcc-${GCC_VERSION} 90 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

apt-get -qq install g++-${GCC_VERSION}
update-alternatives --install /usr/bin/gcc gcc \
/usr/bin/gcc-${GCC_VERSION} 90 \
--slave /usr/bin/g++ g++ /usr/bin/g++-${GCC_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

wget -qO - http://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
sudo add-apt-repository -y "deb http://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${CLANG_VERSION} main"
sudo apt-get -y --allow-unauthenticated update
sudo apt-get -qq install clang-${CLANG_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086



if $INSATLL_CLANG_TOOLS; then
sudo apt-get -y --force-yes -qq install clang-$CLANG_VERSION clang-tools-$CLANG_VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086



if $INSATLL_CLANG_TOOLS; then
sudo apt-get -y --force-yes -qq install clang-$CLANG_VERSION clang-tools-$CLANG_VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086


sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
sudo apt-get -y --allow-unauthenticated update
sudo apt-get -qq install g++-${GCC_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

. /etc/os-release
MAJOR_VERSION=$(echo ${VERSION_ID} | cut -d '.' -f1)

if [[ ${MAJOR_VERSION} -lt 19 ]]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
In POSIX sh, [[ ]] is undefined. SC2039

. /etc/os-release
MAJOR_VERSION=$(echo ${VERSION_ID} | cut -d '.' -f1)

if [ ${MAJOR_VERSION} -lt 19 ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #411 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #411   +/-   ##
========================================
  Coverage    96.70%   96.70%           
========================================
  Files          210      210           
  Lines        10532    10532           
========================================
  Hits         10185    10185           
  Misses         347      347           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b0372...701b24c. Read the comment docs.

@srz-zumix srz-zumix merged commit 527e4f3 into develop Apr 13, 2020
@srz-zumix srz-zumix deleted the feature/update_install_scripts branch April 13, 2020 00:55
@srz-zumix srz-zumix added the CI label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant