fix format nonliteral #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
+ Coverage 96.72% 96.74% +0.01%
===========================================
Files 213 213
Lines 10683 10744 +61
===========================================
+ Hits 10333 10394 +61
Misses 350 350
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
test/unit_string_tests.cpp
Outdated
| } | ||
| IUTEST(UnitStringTest, InvalidVsnprintf) | ||
| { | ||
| IUTEST_EXPECT_EQ(-1, test_iu_vsnprintf(NULL, 1, "test")); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
If you can, use sizeof(NULL) instead of 1 as the 2nd arg to snprintf. [runtime/printf] [3]
ghost
reviewed
May 24, 2020
test/unit_string_tests.cpp
Outdated
| } | ||
| IUTEST(UnitStringTest, InvalidVsnprintf) | ||
| { | ||
| IUTEST_EXPECT_EQ(-1, test_iu_vsnprintf(NULL, 1, "test")); |
There was a problem hiding this comment.
[cpplint] If you can, use sizeof(NULL) instead of 1 as the 2nd arg to snprintf. (view)
| Rule | Confidence |
|---|---|
runtime/printf |
3 |
You can close this issue if no need to fix it. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.