add optional matcher #508
add optional matcher #508
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
include/internal/iutest_stdlib.hpp
Outdated
| typedef T value_type; | ||
| public: | ||
| optional() IUTEST_CXX_NOEXCEPT_SPEC : m_ptr(NULL) {} | ||
| optional(nullpot_t) IUTEST_CXX_NOEXCEPT_SPEC : m_ptr(NULL) {} |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
include/iutest_matcher.hpp
Outdated
| class OptionalMatcher : public IMatcher | ||
| { | ||
| public: | ||
| OptionalMatcher(const T& expected) |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
include/internal/iutest_stdlib.hpp
Outdated
| typedef T value_type; | ||
| public: | ||
| optional() IUTEST_CXX_NOEXCEPT_SPEC : m_ptr(NULL) {} | ||
| optional(nullpot_t) IUTEST_CXX_NOEXCEPT_SPEC : m_ptr(NULL) {} |
There was a problem hiding this comment.
[cpplint] Single-parameter constructors should be marked explicit. (view)
| Rule | Confidence |
|---|---|
runtime/explicit |
5 |
You can close this issue if no need to fix it. Learn more.
include/iutest_matcher.hpp
Outdated
| class OptionalMatcher : public IMatcher | ||
| { | ||
| public: | ||
| OptionalMatcher(const T& expected) |
There was a problem hiding this comment.
[cpplint] Single-parameter constructors should be marked explicit. (view)
| Rule | Confidence |
|---|---|
runtime/explicit |
5 |
You can close this issue if no need to fix it. Learn more.
Codecov Report
@@ Coverage Diff @@
## develop #508 +/- ##
========================================
Coverage 96.89% 96.90%
========================================
Files 220 220
Lines 11263 11297 +34
========================================
+ Hits 10913 10947 +34
Misses 350 350
Continue to review full report at Codecov.
|
#73