Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid deprecated special function call #58

Merged

Conversation

yumetodo
Copy link
Contributor

when copy ctor/assign op is user-provided,
calling copy assign op/ctor is deprecated in C++11 or later.

ref:

when copy ctor/assign op is user-provided,
calling copy assign op/ctor is deprecated in C++11 or later.

ref:
- http://d.hatena.ne.jp/yohhoy/20140704/p1
@yumetodo yumetodo changed the title fix: avoid deprecated special function all fix: avoid deprecated special function call May 31, 2018
@yumetodo
Copy link
Contributor Author

正直本当にこのIUTEST_PP_DISALLOW_ASSIGNは必要か?という思いであふれる。matcher回り。

@yumetodo
Copy link
Contributor Author

yumetodo commented May 31, 2018

IUTEST_PP_DISALLOW_ASSIGNでcopy assign opがuser-providedになるのでcopy ctorも定義しないとダメなんですが、修正範囲がでかすぎてやってられないのでCIが通ればとりあえずいいやで書いています。


なんでci/bitrise/aefa67ee488094b1/prwercker/gcc-7-3-0こけているんだろうか・・・(見れない)

@srz-zumix
Copy link
Owner

ci/bitrise/aefa67ee488094b1/pr — Failed - iutest-android
iutest-android は今ビルド通らないです。申し訳ありませんmm
wercker の方は権限見てみますmm
あと、IUTEST_PP_DISALLOW_ASSIGN は見直しますmm

@srz-zumix
Copy link
Owner

wercker は public になってませんでした。
あと、失敗してたのは環境セットアップに失敗してたので wercker 側の問題ですね。
(たまに失敗するんですよね・・・)

@yumetodo
Copy link
Contributor Author

travisもこけてますが、エラー内容的に本Pull Requestの対象ではないのでひとまずこれで作業完了かなと思うのですが、どうでしょうか?

@srz-zumix srz-zumix self-requested a review May 31, 2018 05:45
@srz-zumix srz-zumix merged commit d4e68d9 into srz-zumix:master May 31, 2018
@yumetodo yumetodo deleted the fix/avoid_deprecated_special_function_call branch May 31, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants