Added log_message_callback #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @coral Thank you for the contribution! Overall looks good, but I will review closer at a later date. Can you please rebase to get the CI fixes to this branch as well? It should help with the build errors. |
ssalonen
requested changes
Dec 5, 2021
|
@ssalonen Implemented the suggested changes and hopefully I managed to rebase (or at least I think so, not a git expert). Feel free to squash all my commits when merging as well. |
ssalonen
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for the
log_message_callbackin order to easier write code for applications that monitor the feed rather than acts as a remote.I tried to keep it relatively similar to what was already in the repo (great Rust btw, learned some new tricks from this repo). I did run the tests, ran clippy and rustfmt. Hope it's decent enough.
Sidenote: Thanks a lot for taking the time to write this wrapper in Rust, very much appreciate it.