Make logging behave #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all custom logging magic, and changes the behaviour to the standard way of logging for Python libraries. In short, instead of magic global loggers and setting global configuration (so that applications experience problems), all logging calls are simply emitted on module-level loggers. It's up to the application to route these messages somewhere useful by configuring handlers and setting levels. Fixes #11.
|
|
ssato
added a commit
that referenced
this pull request
Mar 14, 2015
|
Thanks a lot for the fix. You're right. Merged as it is. |
|
Great @ssato. Any chance you could publish a new release with this fix? Thanks! |
|
I've just released the new version that fix was included. Please let me know if you any issues w/ it. |
|
Awesome, thanks @ssato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all custom logging magic, and changes the behaviour to
the standard way of logging for Python libraries.
In short, instead of magic global loggers and setting global
configuration (so that applications experience problems), all logging
calls are simply emitted on module-level loggers. It's up to the
application to route these messages somewhere useful by configuring
handlers and setting levels.
Fixes #11.