Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable anonymous ping #3

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Enable anonymous ping #3

merged 2 commits into from
Mar 27, 2021

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Mar 26, 2021

After upgrading to ssb-room-client I noticed that ping for direct connections was not working anymore in the browser. This fixes that.

@staltz
Copy link
Member

staltz commented Mar 26, 2021

Can you help me figure out which module is calling tunnel.ping? I've been hunting for that.

@arj03
Copy link
Member Author

arj03 commented Mar 26, 2021

In browser core it is done here. This is the we can't do the slow ping part. And it seems like dominic needed it for the same purpose: https://github.com/ssbc/ssb-tunnel/blob/64eba7e5782fa22a0b61fb77215f51a244ebdb02/examples/browser/index.js

@staltz staltz merged commit 1d45609 into main Mar 27, 2021
@staltz staltz deleted the anonymous-ping branch March 27, 2021 08:36
@staltz
Copy link
Member

staltz commented Mar 27, 2021

Released 0.9.0

@arj03
Copy link
Member Author

arj03 commented Mar 27, 2021

Thank you :-)

@staltz
Copy link
Member

staltz commented Jul 14, 2023

@arj03 I know this is a mega old issue, but I was thinking whether we still need ping in ppppp hubs (similar to ssb rooms) and you said that the browser closes connections after 30 seconds of inactivity: https://github.com/arj03/ssb-browser-core/blob/193a6983892e459f2ebccc335694c20df603480e/net.js#L106

But could it be that this "30" seconds actually came from this config? https://github.com/arj03/ssb-browser-core/blob/193a6983892e459f2ebccc335694c20df603480e/net.js#L32

Or do you think the browser itself has this restriction on websockets?

@arj03
Copy link
Member Author

arj03 commented Jul 14, 2023

@staltz I think it was websockets closing the connection, but it could be that option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants