add test for live pull-stream

[staltz]

Context

Sometimes in Manyverse upon closing the app I would get the error below, but today I also got this error in some test code in ssb-db2, and that finally allowed me to debug it easily.

Uncaught Exception at  uncaughtException : Error: async-append-only-log stream is closed
    at streamClosedErr (./node_modules/async-append-only-log/errors.js:46:10)
    at closeAfterDeletesFlushed (./node_modules/async-append-only-log/index.js:517:57)
    at onDeletesFlushed (./node_modules/async-append-only-log/index.js:308:42)
    at closeAfterHavingDrained (./node_modules/async-append-only-log/index.js:516:7)
    at onDrain (./node_modules/async-append-only-log/index.js:536:67)
    at close (./node_modules/async-append-only-log/index.js:515:5)
    at Object.waitForLogLoaded [as close] (./node_modules/async-append-only-log/index.js:527:12)
    at ./db.js:663:11
    at ./node_modules/multicb/index.js:41:13
    at ./node_modules/levelup/lib/levelup.js:142:16

Problem

As you can see, it's the streamClosedErr from AAOL, but what's puzzling is that this error is only used when closing the AAOL, it's sent to stream.abort(). But the push-stream implementation we have doesn't throw that error anywhere.

Finally, I realized that this throwing happens somewhere in the pull-stream stack. We have live log streams that are converted to pull-stream.

Solution

1st ❌ 2nd ✔️

Just abort with true. I don't see a real need to have the abortion as an actual Error, since in this case we just want to cancel the live streams and close() AAOL.

[arj03]

nice find 👍