Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid another top-level return in index.js #6

Merged
merged 1 commit into from
May 5, 2017

Conversation

staltz
Copy link
Member

@staltz staltz commented May 4, 2017

Sorry to bore you even further @dominictarr, but this one sneaked through as well.

Removes a return that is not inside a function since it a syntax error and is caught by some interpreters.

Remove a `return` that is not inside a function since it a syntax error and is caught by some interpreters.
This change is important for using Chloride in React Native.
@dominictarr
Copy link
Contributor

Please don't make PRs for code with the github editor - I can tell because it uses names the branch patch-1. If you had fixed this locally, you'd have found both instances and gotten it working locally, and made just one PR. the github editor should just be used for documentation.

@dominictarr dominictarr merged commit 83381b9 into ssbc:master May 5, 2017
@dominictarr
Copy link
Contributor

anyway, merged into 2.2.6

@staltz staltz deleted the patch-1 branch May 6, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants