Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for udp6 multicast #6

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

jedahan
Copy link

@jedahan jedahan commented Aug 19, 2018

So this is my first attempt at supporting udp6 multicast for broadcast-stream.

It is off by default, and uses ff02::114 but you can override that.

I also added a lua dissector for wireshark as a useful utility, but maybe that should be in a subfolder like util/ or contrib/ ?

Would love to get your feedback. Cheers!

@jedahan
Copy link
Author

jedahan commented Aug 19, 2018

FYI this is not ready to merge

@dominictarr
Copy link
Contributor

please don't put any thing ssb specific in this module, but happy to add links to things. also keep it es5 (so no destructuring please).
let me know when it's ready

Copy link
Author

@jedahan jedahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is actually ready, I'll test this week and report back.

@@ -34,18 +57,22 @@ module.exports = function (port, loopback) {
var latest = null

socket.on('message', function (msg, other) {
if(addresses[other.address] && other.port === port) {
if(loopback === false) return
console.log(msg.toString())
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants