fix: error out if repoPath doesn't exist; user-facing username/public key -> SSB-ID #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentral1se
commented
Apr 6, 2022
There was a problem hiding this comment.
Although hmmm wait a sec, I see in https://github.com/ssb-ngi-pointer/go-ssb-room/blob/master/web/i18n/defaults/active.en.toml that "public key", "SSB identity" and "SSB ID" are used. Do we want to only use one? I might be missing the difference but I think they're all the same or?
|
They're all the same, yeah. SSB ID would be my default choice, but I don't mind the others. |
decentral1se
force-pushed
the
insert-user-username-fix
branch
from
7f3d86b
to
6c93b00
Compare
decentral1se
changed the title
|
OK maybe 87c58b1 works then, amended the commit 馃檹 |
decentral1se
force-pushed
the
insert-user-username-fix
branch
from
6c93b00
to
f95e916
Compare
decentral1se
force-pushed
the
insert-user-username-fix
branch
from
f95e916
to
87c58b1
Compare
decentral1se
pushed a commit
to decentral1se/go-ssb-room
that referenced
this pull request
Apr 9, 2022
Follows ssbc#308.
Merged
decentral1se
pushed a commit
to decentral1se/go-ssb-room
that referenced
this pull request
Apr 10, 2022
Follows ssbc#308.
staltz
pushed a commit
that referenced
this pull request
Aug 22, 2022
Follows #308. Co-authored-by: decentral1se <cellarspoon@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might close #275?
(My german is awful, sorry 馃檲)